-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix heading overlap #4261
base: master
Are you sure you want to change the base?
Fix heading overlap #4261
Conversation
Review app deployed to https://get-into-teaching-app-review-4261.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Have tagged @jenhadfield-dfe for a review before this is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
This can be merged first thing on Monday morning :-) |
Trello card
https://trello.com/c/wo4ao4Nj/6765-fix-overlapping-headings-on-inspiration-navigation-cards?filter=member:spencerldixon
Context
Headings on inspiration navigation cards that wrap onto two lines are overlapping.
We need to fix the styling so that the words aren’t overlapping.
Changes proposed in this pull request
I find the
highlight-text
mixin isn't working properly and causes multilines of text to overlap.highlight-text
mixin to apply styles to a secondspan
tag that is set torelative
to create a new stacking context where the text sits on top of the previous span, used as the background.span
wherever we encounter overlapGuidance to review